feat(parser): parse CALLED ON NULL INPUT as a property instead of Command#7792
Merged
Merged
Conversation
geooo109
reviewed
Jun 24, 2026
geooo109
left a comment
geooo109
left a comment
Collaborator
There was a problem hiding this comment.
Nice work! left some comments to take into account
geooo109
reviewed
Jun 24, 2026
Co-authored-by: Giorgos Michas <geomichas96@gmail.com>
geooo109
approved these changes
Jun 24, 2026
geooo109
approved these changes
Jun 24, 2026
geooo109
left a comment
geooo109
left a comment
Collaborator
There was a problem hiding this comment.
Great work, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4916
CREATE FUNCTION ... CALLED ON NULL INPUTfalls back toexp.Commandfor every dialect, losing the AST representation. This PR aims to fix it by addingCalledOnNullInputPropertyso the statement parses correctly asexp.Create.The parser hook is added to the
baseparser rather than scoped to a single dialect (original issue reports Snowflake). This fixes Snowflake, Postgres, BigQuery, and the basesqlglotdialect. Added tests to cover Snowflake, Postgres and extendedidentity.sqlto validate the defaultsqlglotdialect.